Fixes for tests where we expect a masked array but get a NaN array #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Member
|
To be clear, these contain NaNs because we ask them to when we do some form of interpolation. |
pelson
approved these changes
Sep 15, 2017
Member
|
👍 once the tests are passing. |
Contributor
Author
|
Quick, merge this before Travis changes its mind! |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these fixes simply replace the CML with the new result. They are all cases where the data should contain NaNs, but Iris was interpreting them as a mask. Diffing with the v1.13.0 cml files shows them to be identical bar core-dtype.